Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: runtime/bin/vmservice_impl.h

Issue 584023004: Service isolate rework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice_impl.h
diff --git a/runtime/bin/vmservice_impl.h b/runtime/bin/vmservice_impl.h
index dde20361f011b653d41db7020963922946896986..80ad7ca5dcf1f4f386ab988f93a21a94cfdca3db 100644
--- a/runtime/bin/vmservice_impl.h
+++ b/runtime/bin/vmservice_impl.h
@@ -14,13 +14,12 @@ namespace bin {
class VmService {
public:
- // Returns false if service could not be started.
- static bool Start(const char *server_ip, intptr_t server_port);
// Error message if startup failed.
static const char* GetErrorMessage();
+ static bool Setup(const char* server_ip, intptr_t server_port);
+
private:
- static bool _Start(const char *server_ip, intptr_t server_port);
static Dart_Handle GetSource(const char* name);
static Dart_Handle LoadScript(const char* name);
static Dart_Handle LoadSource(Dart_Handle library, const char* name);
@@ -31,7 +30,6 @@ class VmService {
friend void TriggerResourceLoad(Dart_NativeArguments args);
- static void ThreadMain(uword parameters);
static const char* error_msg_;
DISALLOW_ALLOCATION();
DISALLOW_IMPLICIT_CONSTRUCTORS(VmService);

Powered by Google App Engine
This is Rietveld 408576698