Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 584023003: Revert of Telemetry: Use the leftmost argument to find the test to parse flags. (Closed)

Created:
6 years, 3 months ago by jbroman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Telemetry: Use the leftmost argument to find the test to parse flags. (patchset #2 id:20001 of https://codereview.chromium.org/582793002/) Reason for revert: Broke Android debug gpu bot: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/12692 This bot relies on being able to supply some flags before the test name; it runs: content/test/gpu/run_gpu_test.py --browser=android-content-shell webgl_conformance --webgl-conformance-version=1.0.1 Original issue's description: > Telemetry: Use the leftmost argument to find the test to parse flags. > > Previously it would check all of the arguments, and use the last test found. > This is causes problems as different tests can be used to create the parser and > accepts the parsed flags. > > SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark > or run_gpu_test.py appear, this is likely the cause. It is safe to revert. > > BUG=413334 > > Committed: https://crrev.com/5afe5a61f03743bd523dae66f662ad773f8befb9 > Cr-Commit-Position: refs/heads/master@{#295738} TBR=nednguyen@google.com,kbr@chromium.org,tonyg@chromium.org,dtu@chromium.org,ariblue@google.com NOTREECHECKS=true NOTRY=true BUG=413334 Committed: https://crrev.com/a66c92ff74876c9bd5a025a1bfa544956f0db94c Cr-Commit-Position: refs/heads/master@{#295765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M tools/telemetry/telemetry/test_runner.py View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
Created Revert of Telemetry: Use the leftmost argument to find the test to parse flags.
6 years, 3 months ago (2014-09-19 19:31:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584023003/1
6 years, 3 months ago (2014-09-19 19:32:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0fc33036c06ae0706a6aa0c69a5cff17d7d74f5c
6 years, 3 months ago (2014-09-19 19:33:03 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:34:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a66c92ff74876c9bd5a025a1bfa544956f0db94c
Cr-Commit-Position: refs/heads/master@{#295765}

Powered by Google App Engine
This is Rietveld 408576698