Issue 584023002: [WIP] Implement Notifications through Platform instead of WebFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 584023002: [WIP] Implement Notifications through Platform instead of WebFrame. (Closed)

Created:
6 years, 3 months ago by Peter Beverloo

Modified:
6 years, 2 months ago

Reviewers:

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[WIP] Implement Notifications through Platform instead of WebFrame. BUG=

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -747 lines)			Patch
M	Source/modules/modules.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/modules/notifications/Notification.h	View	6 chunks	+15 lines, -10 lines	0 comments	Download
M	Source/modules/notifications/Notification.cpp	View	8 chunks	+42 lines, -29 lines	0 comments	Download
M	Source/modules/notifications/Notification.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	Source/modules/notifications/NotificationClient.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
D	Source/modules/notifications/NotificationController.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	Source/modules/notifications/NotificationController.cpp	View	1 chunk	+0 lines, -74 lines	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/web/NotificationPermissionClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/web/NotificationPresenterImpl.h	View	1 chunk	+0 lines, -60 lines	0 comments	Download
D	Source/web/NotificationPresenterImpl.cpp	View	1 chunk	+0 lines, -80 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
D	Source/web/WebNotification.cpp	View	1 chunk	+0 lines, -124 lines	0 comments	Download
M	Source/web/web.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	public/platform/Platform.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	public/platform/WebNotificationData.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	public/platform/WebNotificationDelegate.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A +	public/platform/WebNotificationManager.h	View	1 chunk	+20 lines, -18 lines	0 comments	Download
M	public/web/WebFrameClient.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
D	public/web/WebNotification.h	View	1 chunk	+0 lines, -120 lines	0 comments	Download
D	public/web/WebNotificationPresenter.h	View	1 chunk	+0 lines, -70 lines	0 comments	Download