chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm - Issue 584013002: Componentize history_types.{cc,h} and android_history_types.{cc,h}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

Issue 584013002: Componentize history_types.{cc,h} and android_history_types.{cc,h} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/navigation_popup.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

index e2adc9a91aff2b51f02aa503b85a892aed83de1d..109fb6076f4ef442396751cd597661ff41856057 100644

--- a/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm

@@ -8,7 +8,6 @@

#include "chrome/app/chrome_command_ids.h" // IDC_HISTORY_MENU

#import "chrome/browser/app_controller_mac.h"

#include "chrome/browser/history/history_service.h"

-#include "chrome/browser/history/history_types.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sessions/tab_restore_service.h"

#include "chrome/browser/sessions/tab_restore_service_factory.h"

@@ -17,6 +16,7 @@

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_tab_restore_service_delegate.h"

#include "chrome/browser/ui/host_desktop.h"

+#include "components/history/core/browser/history_types.h"

#import "ui/base/cocoa/cocoa_base_utils.h"

#include "ui/base/window_open_disposition.h"

« no previous file with comments | « chrome/browser/ui/android/navigation_popup.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »