Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 584003002: Revert of mojo: Add deserialization to python structs. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/588493002/) Reason for revert: Linux Tests mojo_python_bindings_tests failure http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712 ====================================================================== ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles) File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize serialization_object.Deserialize(fields, data, handles) File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize (_, version) = HEADER_STRUCT.unpack_from(data) TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray Original issue's description: > mojo: Add deserialization to python structs. > > This is a reland of https://codereview.chromium.org/578263003 using > buffer instead of memoryview, because on some early version of python > 2.7, memoryview cannot be used with struct.unpack_from. > > BUG=415491 > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/37dd5f484593b1c8b92b825a9648edf7fb6944e6 > Cr-Commit-Position: refs/heads/master@{#295684} TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true BUG=415491 Committed: https://crrev.com/9db2dffd5345c110d646846e03a9e7ee8a496e04 Cr-Commit-Position: refs/heads/master@{#295689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -254 lines) Patch
M mojo/public/python/mojo/bindings/descriptor.py View 18 chunks +19 lines, -132 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/public/python/mojo/bindings/serialization.py View 3 chunks +6 lines, -32 lines 0 comments Download
M mojo/python/tests/bindings_serialization_deserialization_unittest.py View 3 chunks +4 lines, -82 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vasilii
Created Revert of mojo: Add deserialization to python structs.
6 years, 3 months ago (2014-09-19 12:24:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584003002/1
6 years, 3 months ago (2014-09-19 12:24:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4bea83b02e5848ca127656bb937ca5fd48908d03
6 years, 3 months ago (2014-09-19 12:25:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9db2dffd5345c110d646846e03a9e7ee8a496e04 Cr-Commit-Position: refs/heads/master@{#295689}
6 years, 3 months ago (2014-09-19 12:25:57 UTC) #4
sdefresne
6 years, 3 months ago (2014-09-19 12:49:47 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698