[Thread-safe] Take isolatedCopy of SecurityOrigin in ResourceLoaderOptions when passed across thread

[Thread-safe] Take isolatedCopy() of SecurityOrigin in ResourceLoaderOptions

To prevent from sharing SecurityOrigin across threads, CrossThreadCopier
should take isolatedCopy() of SecurityOrigin in ResourceLoaderOptions.

BUG=415865
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183967

[hiroshige, 2014-09-19 09:49:38]

hiroshige@chromium.org changed reviewers:
+ abarth@chromium.org, tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2014-09-24 06:43:38]

lgtm

[hiroshige, 2014-10-16 09:18:59]

abarth@, could you take a look as a owner?

Added a unit test for the deep copying of ResourceLoaderOptions.
Added const to TextPosition.h to compile the unit test.

[abarth-chromium, 2014-10-16 16:21:31]

lgtm

https://codereview.chromium.org/583903003/diff/40001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceLoaderOptionsTest.cpp (right):

https://codereview.chromium.org/583903003/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceLoaderOptionsTest.cpp:13: #include <gmock/gmock.h>
Why do we need gmock?

[hiroshige, 2014-10-20 05:19:01]

Thank you for reviewing!

https://codereview.chromium.org/583903003/diff/40001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceLoaderOptionsTest.cpp (right):

https://codereview.chromium.org/583903003/diff/40001/Source/core/fetch/Resour...
Source/core/fetch/ResourceLoaderOptionsTest.cpp:13: #include <gmock/gmock.h>
Removed.

[hiroshige, 2014-10-20 05:20:21]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2014-10-20 05:20:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583903003/60001

[commit-bot: I haz the power, 2014-10-20 05:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 05:20:43]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 3503.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
53bf851a39021ddfcd99c28c9cd64c0a00f9fc86..a59057b2b10c7e7281e2d11590815a6ccbe4573a
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -3503,6 +3503,7 @@
             'fetch/MemoryCacheTest.cpp',
             'fetch/RawResourceTest.cpp',
             'fetch/ResourceFetcherTest.cpp',
+            'fetch/ResourceLoaderOptionsTest.cpp',
             'frame/ImageBitmapTest.cpp',
             'html/HTMLDimensionTest.cpp',
             'html/HTMLFormControlElementTest.cpp',

[hiroshige, 2014-10-20 05:36:40]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2014-10-20 05:37:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583903003/80001

[commit-bot: I haz the power, 2014-10-20 07:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 07:25:53]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32523)

[hiroshige, 2014-10-20 09:23:53]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2014-10-20 09:24:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583903003/80001

[commit-bot: I haz the power, 2014-10-20 09:57:45]

Committed patchset #5 (id:80001) as 183967