Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 583883002: Adds TCP FastOpen blackhole recovery code to avoid getting persistently blackholed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits addressed and histogram updated. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/socket/tcp_socket_libevent.cc ('K') | « net/socket/tcp_socket_libevent.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 92404c70a7adfe55f4219c097abc9088ff61389d..44989d77d239c433064c99dffbbc1b3df30e1785 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -17731,7 +17731,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Net.TcpFastOpenSocketConnection" enum="TcpSocketStatus">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>jri@chromium.org</owner>
<summary>
For sockets for which a TCP Fast Open protocol might be used, the result of
trying to use it.
@@ -51303,10 +51303,13 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="Connection Error"/>
<int value="4" label="Syn Data Acknowledged"/>
<int value="5" label="Syn Data Nacked"/>
- <int value="6" label="Syn Data Probe Failed"/>
- <int value="7" label="No syn data + ack (can't happen)"/>
- <int value="8" label="No syn data + nack"/>
- <int value="9" label="No syn data + probe failed"/>
+ <int value="6" label="Syn Data Getsockopt Failed"/>
+ <int value="7" label="No Syn Data + Ack (can't happen)"/>
+ <int value="8" label="No Syn Data + Nack"/>
+ <int value="9" label="No Syn Data + Getsockopt Failed"/>
+ <int value="10" label="Fast Connect + Read Failed"/>
+ <int value="11" label="Slow Connect + Read Failed"/>
+ <int value="12" label="Previously Failed"/>
</enum>
<enum name="TileMemoryBudget" type="int">
« net/socket/tcp_socket_libevent.cc ('K') | « net/socket/tcp_socket_libevent.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698