Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 583873003: Breakpad Linux: Add some debug logging for crash id generation failures. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
vapier
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Breakpad Linux: Add some debug logging for crash id generation failures. BUG=415382 Committed: https://crrev.com/62bb80ad12b37f318b69b77c137a943b673cc59f Cr-Commit-Position: refs/heads/master@{#295756}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rephrase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M components/crash/app/breakpad_linux.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-09-19 06:15:55 UTC) #2
vapier
lgtm i updated the chrome collector in crash-reporter to log whenever it gets run, so ...
6 years, 3 months ago (2014-09-19 16:14:24 UTC) #3
Lei Zhang
https://codereview.chromium.org/583873003/diff/1/components/crash/app/breakpad_linux.cc File components/crash/app/breakpad_linux.cc (right): https://codereview.chromium.org/583873003/diff/1/components/crash/app/breakpad_linux.cc#newcode1085 components/crash/app/breakpad_linux.cc:1085: static const char msg[] = "Crash_reporter failed to process ...
6 years, 3 months ago (2014-09-19 18:26:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583873003/20001
6 years, 3 months ago (2014-09-19 18:27:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9f7661f03f3c345241eb975967354fcc17d7d1f1
6 years, 3 months ago (2014-09-19 19:06:06 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:06:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62bb80ad12b37f318b69b77c137a943b673cc59f
Cr-Commit-Position: refs/heads/master@{#295756}

Powered by Google App Engine
This is Rietveld 408576698