sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart - Issue 583853002: Use precompiled dependencies in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart

Issue 583853002: Use precompiled dependencies in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart

diff --git a/sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart b/sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart

index a7ae9b0dd511d20c6beaae85f4c67b0cc58201eb..20349ec429ff1f775b17a2dca55f6beee9ae48b9 100644

--- a/sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart

+++ b/sdk/lib/_internal/pub_generated/lib/src/validator/executable.dart

@@ -11,8 +11,7 @@ class ExecutableValidator extends Validator {

try {

var binFiles = entrypoint.root.listFiles(

beneath: "bin",

- recursive: false).map(

- ((path) => p.relative(path, from: entrypoint.root.dir))).toList();

+ recursive: false).map(((path) => entrypoint.root.relative(path))).toList();

entrypoint.root.pubspec.executables.forEach(((executable, script) {

var scriptPath = p.join("bin", "$script.dart");

if (binFiles.contains(scriptPath)) return;