Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: sdk/lib/_internal/pub/lib/src/command/barback.dart

Issue 583853002: Use precompiled dependencies in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/cached_package.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/command/barback.dart
diff --git a/sdk/lib/_internal/pub/lib/src/command/barback.dart b/sdk/lib/_internal/pub/lib/src/command/barback.dart
index bfae53be98586d183e144139cb37a24df4571919..6f67c39dba3fa12ae5ec07cc6ece7e0c1ad2c407 100644
--- a/sdk/lib/_internal/pub/lib/src/command/barback.dart
+++ b/sdk/lib/_internal/pub/lib/src/command/barback.dart
@@ -107,7 +107,7 @@ abstract class BarbackCommand extends PubCommand {
// Make sure all of the source directories exist.
var missing = sourceDirectories.where(
- (dir) => !dirExists(path.join(entrypoint.root.dir, dir)));
+ (dir) => !dirExists(entrypoint.root.path(dir)));
if (missing.isNotEmpty) {
dataError(_directorySentence(missing, "does", "do", "not exist"));
@@ -142,7 +142,7 @@ abstract class BarbackCommand extends PubCommand {
// Include every build directory that exists in the package.
var dirs = _allSourceDirectories.where(
- (dir) => dirExists(path.join(entrypoint.root.dir, dir)));
+ (dir) => dirExists(entrypoint.root.path(dir)));
if (dirs.isEmpty) {
var defaultDirs = toSentence(_allSourceDirectories.map(
@@ -158,7 +158,7 @@ abstract class BarbackCommand extends PubCommand {
/// on the command line.
void _addDefaultSources() {
sourceDirectories.addAll(defaultSourceDirectories.where(
- (dir) => dirExists(path.join(entrypoint.root.dir, dir))));
+ (dir) => dirExists(entrypoint.root.path(dir))));
// TODO(rnystrom): Hackish. Assumes there will only be one or two
// default sources. That's true for pub build and serve, but isn't as
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/cached_package.dart ('k') | sdk/lib/_internal/pub/lib/src/command/build.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698