sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart - Issue 583853002: Use precompiled dependencies in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

Issue 583853002: Use precompiled dependencies in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart ('k') | sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

diff --git a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

index bba80c574d2cb05459abe9747fd50e3d0b747598..e112db2bb5a02c9c325398d155ff8951522efcda 100644

--- a/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

+++ b/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart

@@ -12,7 +12,6 @@ import '../utils.dart';

import 'asset_environment.dart';

import 'barback_server.dart';

import 'rewrite_import_transformer.dart';

-import 'transformer_cache.dart';

import 'transformer_id.dart';

import 'transformer_loader.dart';

import 'transformers_needed_by_transformers.dart';

@@ -28,8 +27,7 @@ import 'transformers_needed_by_transformers.dart';

Future loadAllTransformers(AssetEnvironment environment,

BarbackServer transformerServer) async {

var transformersNeededByTransformers =

- computeTransformersNeededByTransformers(environment.graph,

- packages: environment.packages);

+ computeTransformersNeededByTransformers(environment.graph);

var buffer = new StringBuffer();

buffer.writeln("Transformer dependencies:");

@@ -52,7 +50,7 @@ Future loadAllTransformers(AssetEnvironment environment,

// Add a rewrite transformer for each package, so that we can resolve

// "package:" imports while loading transformers.

var rewrite = new RewriteImportTransformer();

- for (var package in environment.packages) {

+ for (var package in environment.graph.packages.keys) {

environment.barback.updateTransformers(package, [[rewrite]]);

}

environment.barback.updateTransformers(r'$pub', [[rewrite]]);

@@ -94,8 +92,7 @@ Future loadAllTransformers(AssetEnvironment environment,

/// Reset the transformers for each package to get rid of [rewrite], which

/// is no longer needed.

- await Future.wait(environment.packages.map((packageName) async {

- var package = environment.graph.packages[packageName];

+ await Future.wait(environment.graph.packages.values.map((package) async {

var phases = await loader.transformersForPhases(

package.pubspec.transformers);

var transformers = environment.getBuiltInTransformers(package);