Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 583843002: Use analyze.py in Android trybots. (Closed)

Created:
6 years, 3 months ago by jabdelmalek
Modified:
6 years, 3 months ago
Reviewers:
jam, sky, luqui
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Project:
tools
Visibility:
Public.

Description

Use analyze.py in Android trybots. This allows us to early out if the patch can't affect the trybot. If it could affect it, we only build the targets that could be affected, and similarly only run the tests that need to. BUG=405584, 109173 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292042

Patch Set 1 : #

Patch Set 2 : fixes per phajdan #

Patch Set 3 : add 100% test coverage so presubmit pass #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : sky comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -836 lines) Patch
M scripts/slave/recipes/android/tester.py View 1 2 3 4 9 chunks +59 lines, -5 lines 2 comments Download
M scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe.json View 1 2 4 chunks +61 lines, -321 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json View 1 4 chunks +60 lines, -350 lines 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_rel_tests_recipe.json View 1 2 3 chunks +61 lines, -103 lines 0 comments Download
A + scripts/slave/recipes/android/tester.expected/no_compile_because_of_analyze.json View 1 2 3 chunks +35 lines, -57 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
jam
Hey guys, this is a first draft of getting Android recipe to use analyze.py. Thanks ...
6 years, 3 months ago (2014-09-18 23:22:55 UTC) #4
luqui
looks good. I spent a bit of time yesterday setting up a testing environment on ...
6 years, 3 months ago (2014-09-19 00:00:01 UTC) #6
luqui
Looks like it's working. I don't know much about gyp and targets, but here are ...
6 years, 3 months ago (2014-09-19 00:53:12 UTC) #7
luqui
Lol obviously not localhost. Here are the runs: patchset 1: http://luqui.mtv.corp.google.com:8092/builders/android_dbg_tests_recipe/builds/2 patchset 2: http://luqui.mtv.corp.google.com:8092/builders/android_dbg_tests_recipe/builds/3
6 years, 3 months ago (2014-09-19 00:54:00 UTC) #8
jam
On 2014/09/19 00:54:00, luqui wrote: > Lol obviously not localhost. Here are the runs: > ...
6 years, 3 months ago (2014-09-19 01:05:32 UTC) #9
luqui
lgtm, wait for sky though.
6 years, 3 months ago (2014-09-19 01:15:21 UTC) #10
sky
https://codereview.chromium.org/583843002/diff/80001/scripts/slave/recipes/android/tester.py File scripts/slave/recipes/android/tester.py (right): https://codereview.chromium.org/583843002/diff/80001/scripts/slave/recipes/android/tester.py#newcode137 scripts/slave/recipes/android/tester.py:137: for suite in instrumentation_tests: nit: you could shorten this ...
6 years, 3 months ago (2014-09-19 02:46:58 UTC) #11
jam
https://codereview.chromium.org/583843002/diff/80001/scripts/slave/recipes/android/tester.py File scripts/slave/recipes/android/tester.py (right): https://codereview.chromium.org/583843002/diff/80001/scripts/slave/recipes/android/tester.py#newcode137 scripts/slave/recipes/android/tester.py:137: for suite in instrumentation_tests: On 2014/09/19 02:46:57, sky wrote: ...
6 years, 3 months ago (2014-09-19 03:08:11 UTC) #13
sky
Everything else looks right. https://codereview.chromium.org/583843002/diff/100001/scripts/slave/recipes/android/tester.py File scripts/slave/recipes/android/tester.py (right): https://codereview.chromium.org/583843002/diff/100001/scripts/slave/recipes/android/tester.py#newcode148 scripts/slave/recipes/android/tester.py:148: compile_targets = list(set(compile_targets) & Does ...
6 years, 3 months ago (2014-09-19 15:23:02 UTC) #15
jabdelmalek
https://codereview.chromium.org/583843002/diff/100001/scripts/slave/recipes/android/tester.py File scripts/slave/recipes/android/tester.py (right): https://codereview.chromium.org/583843002/diff/100001/scripts/slave/recipes/android/tester.py#newcode148 scripts/slave/recipes/android/tester.py:148: compile_targets = list(set(compile_targets) & the bots don't pass in ...
6 years, 3 months ago (2014-09-19 15:37:53 UTC) #16
sky
LGTM
6 years, 3 months ago (2014-09-19 16:50:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583843002/100001
6 years, 3 months ago (2014-09-19 16:52:06 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:53:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as 292042

Powered by Google App Engine
This is Rietveld 408576698