Set keyboard mic effect if available.

Set keyboard mic effect if available.

* Check if keyboard mic is available in MediaStreamManager and inform AudioManager if so.
* AudioManager sets the effect in AudioParameters returned from GetInputStreamParameters if available.

BUG=345296
Committed: https://crrev.com/2f7682929e1bee07cf754a3a849e1cf905d25f0a
Cr-Commit-Position: refs/heads/master@{#296368}

[Henrik Grunell, 2014-09-20 15:46:43]

grunell@chromium.org changed reviewers:
+ tommi@chromium.org

[Henrik Grunell, 2014-09-20 15:46:44]

https://codereview.chromium.org/583833008/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/media_stream_manager.cc (right):

https://codereview.chromium.org/583833008/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/media_stream_manager.cc:2100:
audio_manager_->SetHasKeyboardMic();
Hmm, I guess the audio manager should be accessed on the device thread, right?
(Although this is a one-off set.)

[tommi (sloooow) - chröme, 2014-09-20 16:00:53]

https://codereview.chromium.org/583833008/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/media/media_stream_manager.cc (right):

https://codereview.chromium.org/583833008/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/media/media_stream_manager.cc:2100:
audio_manager_->SetHasKeyboardMic();
On 2014/09/20 15:46:43, Henrik Grunell wrote:
> Hmm, I guess the audio manager should be accessed on the device thread, right?
> (Although this is a one-off set.)

Looks like |audio_manager_| is already being used on both the IO and UI thread.
However, I don't know if the method itself is thread safe.

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
media/audio/cras/audio_manager_cras.cc:80: const std::string& device_id) {
missing thread check
DCHECK(GetTaskRunner()->BelongsToCurrentThread());
(I think)

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
media/audio/cras/audio_manager_cras.cc:96: has_keyboard_mic_ = true;
missing thread check.  From what I can tell, it should be the same thread as
GetInputStreamParameters is called on and from e.g. the windows implementation
it looks like that's the audio manager's worker thread
(DCHECK(GetTaskRunner()->BelongsToCurrentThread());).

[Henrik Grunell, 2014-09-22 11:11:24]

Also changes in MSM due to the thread check.

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
media/audio/cras/audio_manager_cras.cc:80: const std::string& device_id) {
On 2014/09/20 16:00:53, tommi wrote:
> missing thread check
> DCHECK(GetTaskRunner()->BelongsToCurrentThread());
> (I think)

Done. FYI, there's no thread checks anywhere in this class. (As in the
superclass.)

https://codereview.chromium.org/583833008/diff/20001/media/audio/cras/audio_m...
media/audio/cras/audio_manager_cras.cc:96: has_keyboard_mic_ = true;
On 2014/09/20 16:00:53, tommi wrote:
> missing thread check.  From what I can tell, it should be the same thread as
> GetInputStreamParameters is called on and from e.g. the windows implementation
> it looks like that's the audio manager's worker thread
> (DCHECK(GetTaskRunner()->BelongsToCurrentThread());).

Done.

[tommi (sloooow) - chröme, 2014-09-22 20:30:15]

lgtm % fixing the build error

[Henrik Grunell, 2014-09-23 07:41:35]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2014-09-23 07:42:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583833008/80001

[commit-bot: I haz the power, 2014-09-23 08:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 08:56:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Henrik Grunell, 2014-09-23 14:43:46]

grunell@chromium.org changed reviewers:
+ jennyz@chromium.org

[Henrik Grunell, 2014-09-23 14:46:12]

I had to update tests to initialize Cras for testing since MediaStreamManager
accesses it now.

I added a dep in content/test/DEPS on chromeos/audio. PPAPI test needs this.

PTAL.

Tommi: Tests. (See diff patch set #6 against set #4.)
Jenny: content/test/DEPS

[tommi (sloooow) - chröme, 2014-09-23 17:23:57]

lgtm

[jennyz, 2014-09-23 20:56:35]

lgtm for content/test/DEPS.

[Henrik Grunell, 2014-09-24 07:45:37]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2014-09-24 07:46:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583833008/160001

[commit-bot: I haz the power, 2014-09-24 08:36:12]

Committed patchset #9 (id:160001) as 1292a473677b45e4c38178a29fc8c0058c86d28e

[commit-bot: I haz the power, 2014-09-24 08:36:46]

Patchset 9 (id:??) landed as
https://crrev.com/2f7682929e1bee07cf754a3a849e1cf905d25f0a
Cr-Commit-Position: refs/heads/master@{#296368}