Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 583833007: Revert of Fix update of validity cache value, so that it reflects the correct state of any ... (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserv ed.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 if (maxLength > 0 && U16_IS_LEAD(proposedValue[maxLength - 1])) 313 if (maxLength > 0 && U16_IS_LEAD(proposedValue[maxLength - 1]))
314 --maxLength; 314 --maxLength;
315 return proposedValue.left(maxLength); 315 return proposedValue.left(maxLength);
316 } 316 }
317 317
318 void HTMLTextAreaElement::updateValue() const 318 void HTMLTextAreaElement::updateValue() const
319 { 319 {
320 if (m_valueIsUpToDate) 320 if (m_valueIsUpToDate)
321 return; 321 return;
322 322
323 ASSERT(renderer());
323 m_value = innerEditorValue(); 324 m_value = innerEditorValue();
324 const_cast<HTMLTextAreaElement*>(this)->m_valueIsUpToDate = true; 325 const_cast<HTMLTextAreaElement*>(this)->m_valueIsUpToDate = true;
325 const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged(); 326 const_cast<HTMLTextAreaElement*>(this)->notifyFormStateChanged();
326 m_isDirty = true; 327 m_isDirty = true;
327 const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility(false); 328 const_cast<HTMLTextAreaElement*>(this)->updatePlaceholderVisibility(false);
328 } 329 }
329 330
330 String HTMLTextAreaElement::value() const 331 String HTMLTextAreaElement::value() const
331 { 332 {
332 updateValue(); 333 updateValue();
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
565 { 566 {
566 return true; 567 return true;
567 } 568 }
568 569
569 bool HTMLTextAreaElement::supportsAutofocus() const 570 bool HTMLTextAreaElement::supportsAutofocus() const
570 { 571 {
571 return true; 572 return true;
572 } 573 }
573 574
574 } 575 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698