Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: Source/core/html/HTMLFormControlElement.h

Issue 583833007: Revert of Fix update of validity cache value, so that it reflects the correct state of any ... (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 174
175 // The initial value of m_willValidate depends on the derived class. We can' t 175 // The initial value of m_willValidate depends on the derived class. We can' t
176 // initialize it with a virtual function in the constructor. m_willValidate 176 // initialize it with a virtual function in the constructor. m_willValidate
177 // is not deterministic as long as m_willValidateInitialized is false. 177 // is not deterministic as long as m_willValidateInitialized is false.
178 mutable bool m_willValidateInitialized: 1; 178 mutable bool m_willValidateInitialized: 1;
179 mutable bool m_willValidate : 1; 179 mutable bool m_willValidate : 1;
180 180
181 // Cache of valid(). 181 // Cache of valid().
182 // But "candidate for constraint validation" doesn't affect m_isValid. 182 // But "candidate for constraint validation" doesn't affect m_isValid.
183 bool m_isValid : 1; 183 bool m_isValid : 1;
184 // Dirty flag that controls updating valid() cache.
185 bool m_validityIsDirty : 1;
186 184
187 bool m_wasChangedSinceLastFormControlChangeEvent : 1; 185 bool m_wasChangedSinceLastFormControlChangeEvent : 1;
188 bool m_wasFocusedByMouse : 1; 186 bool m_wasFocusedByMouse : 1;
189 }; 187 };
190 188
191 inline bool isHTMLFormControlElement(const Element& element) 189 inline bool isHTMLFormControlElement(const Element& element)
192 { 190 {
193 return element.isFormControlElement(); 191 return element.isFormControlElement();
194 } 192 }
195 193
196 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement); 194 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
197 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, contro l->isFormControlElement(), control.isFormControlElement()); 195 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, contro l->isFormControlElement(), control.isFormControlElement());
198 196
199 } // namespace 197 } // namespace
200 198
201 #endif 199 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/number/number-validity-badinput-expected.txt ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698