Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 583833002: Fix and re-enable v8 idle notification after commit. (Closed)

Created:
6 years, 3 months ago by ernstm
Modified:
6 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable v8 idle notification after commit. For idle times < 1000us, we sent notifications with 0ms. This patch adds a check for idle_time_in_ms to be non-zero and re-enables the feature by default. R=jochen@chromium.org BUG=414815 Committed: https://crrev.com/5e0a3fde818bfe005bc37100626b188b8d5d7c84 Cr-Commit-Position: refs/heads/master@{#295680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ernstm
PTAL
6 years, 3 months ago (2014-09-18 22:52:50 UTC) #1
jochen (gone - plz use gerrit)
lgtm.
6 years, 3 months ago (2014-09-19 04:01:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583833002/1
6 years, 3 months ago (2014-09-19 04:01:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15400)
6 years, 3 months ago (2014-09-19 05:07:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583833002/1
6 years, 3 months ago (2014-09-19 05:27:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15414)
6 years, 3 months ago (2014-09-19 06:29:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583833002/1
6 years, 3 months ago (2014-09-19 06:33:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4bc4491985cd59e4b5719dac75a1d73b35ec1106
6 years, 3 months ago (2014-09-19 08:36:43 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 08:37:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e0a3fde818bfe005bc37100626b188b8d5d7c84
Cr-Commit-Position: refs/heads/master@{#295680}

Powered by Google App Engine
This is Rietveld 408576698