[chromium] Pass SkBitmap by reference in WebImageLayer::setBitmap

[chromium] Pass SkBitmap by reference in WebImageLayer::setBitmap

Although passing SkBitmap by value doesn't copy the underlying pixels, it indeed involves
memcpy (~64 bytes to be precise) to replicate the settings from the other bitmap in the copy constructor.
Along with this, it has to do some book keeping with respect to reference counts, updating pixel lock count
etc.

This overhead, albeit minor, can be avoided by passing SkBitmap as reference.

R=abarth@chromium.org, jamesr@chromium.org

Committed: https://crrev.com/9461415e61c4995ca4606c9a51ac33d24ebba908
Cr-Commit-Position: refs/heads/master@{#296143}

[vivekg, 2014-09-18 19:08:07]

PTAL, thank you!

[danakj, 2014-09-18 21:43:53]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2014-09-18 21:43:53]

LGTM % blink-side approval

https://codereview.chromium.org/583743002/diff/1/cc/blink/web_image_layer_impl.h
File cc/blink/web_image_layer_impl.h (right):

https://codereview.chromium.org/583743002/diff/1/cc/blink/web_image_layer_imp...
cc/blink/web_image_layer_impl.h:24: virtual void setImageBitmap(const
SkBitmap&);
can you give this argument a variable name to match the .cc file?

[vivekg, 2014-09-19 03:13:43]

On 2014/09/18 at 21:43:53, danakj wrote:
> LGTM % blink-side approval
> 
>
https://codereview.chromium.org/583743002/diff/1/cc/blink/web_image_layer_impl.h
> File cc/blink/web_image_layer_impl.h (right):
> 
>
https://codereview.chromium.org/583743002/diff/1/cc/blink/web_image_layer_imp...
> cc/blink/web_image_layer_impl.h:24: virtual void setImageBitmap(const
SkBitmap&);
> can you give this argument a variable name to match the .cc file?

Done, thank you! I will land it once blink side changes are rolled in.

[vivekg, 2014-09-22 15:05:47]

@jamesr, done the changes as per our discussion. PTAL. Thank you.

[jamesr, 2014-09-22 17:27:02]

lgtm

[vivekg, 2014-09-23 00:55:58]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:57:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583743002/60001

[commit-bot: I haz the power, 2014-09-23 02:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 02:57:56]

Exceeded time limit waiting for builds to trigger.

[vivekg, 2014-09-23 04:30:54]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-09-23 04:31:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583743002/60001

[commit-bot: I haz the power, 2014-09-23 05:04:15]

Committed patchset #4 (id:60001) as d09c6f7633a831c09757f69c4ec8c39ae4a56681

[commit-bot: I haz the power, 2014-09-23 05:04:51]

Patchset 4 (id:??) landed as
https://crrev.com/9461415e61c4995ca4606c9a51ac33d24ebba908
Cr-Commit-Position: refs/heads/master@{#296143}