[blink] Pass SkBitmap by reference in WebImageLayer::setBitmap

public/platform/WebImageLayer.h

Index: public/platform/WebImageLayer.h
diff --git a/public/platform/WebImageLayer.h b/public/platform/WebImageLayer.h
index ee75c569342725f60e948c49529a745d410bc75c..2d502e63ca97517e0c3ecb31a72ca7d74e8031ea 100644
--- a/public/platform/WebImageLayer.h
+++ b/public/platform/WebImageLayer.h
@@ -37,7 +37,8 @@ public:
     virtual ~WebImageLayer() { }
 
     virtual WebLayer* layer() = 0;
-    virtual void setBitmap(SkBitmap) = 0;
+    virtual void setBitmap(SkBitmap) { }

[jamesr, 2014/09/22 14:25:44]

leave a FIXME here indicating what the status of this is supposed to be

[vivekg, 2014/09/22 14:29:28]

Sure, will do! Thank you.

+    virtual void setImageBitmap(const SkBitmap& bitmap) { setBitmap(bitmap); }

[jamesr, 2014/09/22 14:25:44]

if this is the new function, shouldn't this be the other way around? i.e.
setBitmap() calls this function and this function is marked pure virtual (since
you're going to land the chromium side first, right?)

[vivekg, 2014/09/22 14:29:27]

We have to land this first in blink in any case. As without being virtual,
chromium side changes would be no-op and would either break the build or break
the layout tests.

 };
 
 } // namespace blink