build/common.gypi - Issue 58373003: Fix iOS device builds broken by commit d645540

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 58373003: Fix iOS device builds broken by commit d645540 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review feedback Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 06306c8934aeac77a07635c8091b39a1f54a768c..67685df142a5d70c5c4ebb06193f94b88b01fda1 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4664,16 +4664,19 @@

# Target both iPhone and iPad.

'TARGETED_DEVICE_FAMILY': '1,2',

'VALID_ARCHS': 'armv7 i386',

- }],

- ['target_arch=="x64"', {

- 'ARCHS': [

- 'x86_64'

- ],

- }],

- ['target_arch=="ia32"', {

- 'ARCHS': [

- 'i386'

- ],

+ }, {

Mark Mentovai 2013/11/04 20:52:33 Say }, { # OS!="ios" on this line, as is often

kiyun 2013/11/04 21:02:19 Done.

+ 'conditions': [

+ ['target_arch=="x64"', {

+ 'ARCHS': [

+ 'x86_64'

+ ],

+ }],

+ ['target_arch=="ia32"', {

+ 'ARCHS': [

+ 'i386'

+ ],

+ }],

+ ],

}],

« no previous file with comments | « base/memory/discardable_memory_provider_unittest.cc ('k') | no next file » | no next file with comments »