Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: build/common.gypi

Issue 58373003: Fix iOS device builds broken by commit d645540 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/discardable_memory_provider_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4641 matching lines...) Expand 10 before | Expand all | Expand 10 after
4652 }, { 4652 }, {
4653 'SDKROOT': '<(ios_sdk_path)', # -isysroot 4653 'SDKROOT': '<(ios_sdk_path)', # -isysroot
4654 }], 4654 }],
4655 ], 4655 ],
4656 }], 4656 }],
4657 ['OS=="ios"', { 4657 ['OS=="ios"', {
4658 # Target both iPhone and iPad. 4658 # Target both iPhone and iPad.
4659 'TARGETED_DEVICE_FAMILY': '1,2', 4659 'TARGETED_DEVICE_FAMILY': '1,2',
4660 'VALID_ARCHS': 'armv7 i386', 4660 'VALID_ARCHS': 'armv7 i386',
4661 }], 4661 }],
4662 ['target_arch=="x64"', { 4662 ['target_arch=="x64"', {
Mark Mentovai 2013/11/04 20:28:42 How about instead, move this whole block from 4662
kiyun 2013/11/04 20:48:50 Done.
4663 'ARCHS': [ 4663 'ARCHS': [
4664 'x86_64' 4664 'x86_64'
4665 ], 4665 ],
4666 }], 4666 }],
4667 ['target_arch=="ia32"', { 4667 # Mac builds set ARCHS explicitly to i386. Leave ARCHS unspecified for
4668 # iOS builds, so that Xcode will use the appropriate defaults for
4669 # simulator and device builds, which are different architectures.
4670 ['target_arch=="ia32" and OS!="ios"', {
4668 'ARCHS': [ 4671 'ARCHS': [
4669 'i386' 4672 'i386'
4670 ], 4673 ],
4671 }], 4674 }],
4672 ], 4675 ],
4673 4676
4674 # The Xcode generator will look for an xcode_settings section at the root 4677 # The Xcode generator will look for an xcode_settings section at the root
4675 # of each dict and use it to apply settings on a file-wide basis. Most 4678 # of each dict and use it to apply settings on a file-wide basis. Most
4676 # settings should not be here, they should be in target-specific 4679 # settings should not be here, they should be in target-specific
4677 # xcode_settings sections, or better yet, should use non-Xcode-specific 4680 # xcode_settings sections, or better yet, should use non-Xcode-specific
4678 # settings in target dicts. SYMROOT is a special case, because many other 4681 # settings in target dicts. SYMROOT is a special case, because many other
4679 # Xcode variables depend on it, including variables such as 4682 # Xcode variables depend on it, including variables such as
4680 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4683 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4681 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4684 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4682 # files to appear (when present) in the UI as actual files and not red 4685 # files to appear (when present) in the UI as actual files and not red
4683 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4686 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4684 # and therefore SYMROOT, needs to be set at the project level. 4687 # and therefore SYMROOT, needs to be set at the project level.
4685 'SYMROOT': '<(DEPTH)/xcodebuild', 4688 'SYMROOT': '<(DEPTH)/xcodebuild',
4686 }, 4689 },
4687 } 4690 }
OLDNEW
« no previous file with comments | « base/memory/discardable_memory_provider_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698