Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: Source/core/dom/Node.h

Issue 58373002: Whitespace only text nodes need to be reattached when their siblings are reattached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixing reattach logic and killing WhitespaceChildList. Will probably need some updated mac expectat… Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 // the node's rendering object from the rendering tree and delete it. 552 // the node's rendering object from the rendering tree and delete it.
553 virtual void detach(const AttachContext& = AttachContext()); 553 virtual void detach(const AttachContext& = AttachContext());
554 554
555 #ifndef NDEBUG 555 #ifndef NDEBUG
556 bool inDetach() const; 556 bool inDetach() const;
557 #endif 557 #endif
558 558
559 void reattach(const AttachContext& = AttachContext()); 559 void reattach(const AttachContext& = AttachContext());
560 void lazyReattachIfAttached(); 560 void lazyReattachIfAttached();
561 561
562 void reattachWhitespaceSiblings() const;
563
562 // Wrapper for nodes that don't have a renderer, but still cache the style ( like HTMLOptionElement). 564 // Wrapper for nodes that don't have a renderer, but still cache the style ( like HTMLOptionElement).
563 RenderStyle* renderStyle() const; 565 RenderStyle* renderStyle() const;
564 RenderStyle* parentRenderStyle() const; 566 RenderStyle* parentRenderStyle() const;
565 567
566 RenderStyle* computedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) { ret urn virtualComputedStyle(pseudoElementSpecifier); } 568 RenderStyle* computedStyle(PseudoId pseudoElementSpecifier = NOPSEUDO) { ret urn virtualComputedStyle(pseudoElementSpecifier); }
567 569
568 // ------------------------------------------------------------------------- ---- 570 // ------------------------------------------------------------------------- ----
569 // Notification of document structure changes (see ContainerNode.h for more notification methods) 571 // Notification of document structure changes (see ContainerNode.h for more notification methods)
570 // 572 //
571 // At first, WebKit notifies the node that it has been inserted into the doc ument. This is called during document parsing, and also 573 // At first, WebKit notifies the node that it has been inserted into the doc ument. This is called during document parsing, and also
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
939 941
940 } // namespace WebCore 942 } // namespace WebCore
941 943
942 #ifndef NDEBUG 944 #ifndef NDEBUG
943 // Outside the WebCore namespace for ease of invocation from gdb. 945 // Outside the WebCore namespace for ease of invocation from gdb.
944 void showTree(const WebCore::Node*); 946 void showTree(const WebCore::Node*);
945 void showNodePath(const WebCore::Node*); 947 void showNodePath(const WebCore::Node*);
946 #endif 948 #endif
947 949
948 #endif 950 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/Node.cpp » ('j') | Source/core/dom/Node.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698