Whitespace only text nodes need to be reattached when their siblings are reattached

Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 985 matching lines @@
         }
     }
 
     clearFlag(IsAttachedFlag);
 
 #ifndef NDEBUG
     detachingNode = 0;
 #endif
 }
 
+void Node::reattachWhitespaceSiblings() const
+{
+    for (Node* sibling = nextSibling(); sibling; sibling = sibling->nextSibling()) {
+        if (sibling->isTextNode() && toText(sibling)->containsOnlyWhitespace())
+            sibling->reattach();

[leviw_travelin_and_unemployed, 2013/11/04 23:43:09]

The previous version wouldn't reattach whitespace nodes with renderers. Getting
this right fixed the flake.

+        else if (sibling->renderer())
+            return;
+    }
+}
+
 // FIXME: This code is used by editing.  Seems like it could move over there and not pollute Node.
 Node *Node::previousNodeConsideringAtomicNodes() const
 {
     if (previousSibling()) {
         Node *n = previousSibling();
         while (!isAtomicNode(n) && n->lastChild())
             n = n->lastChild();
         return n;
     }
     else if (parentNode()) {
@@ skipping 1614 matching lines @@
         node->showTreeForThis();
 }
 
 void showNodePath(const WebCore::Node* node)
 {
     if (node)
         node->showNodePathForThis();
 }
 
 #endif