Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: src/harmony-typedarray.js

Issue 583723002: Implement .forEach() on typed arrays (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Improve tests, remove harmony_typedarrays flag Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 'use strict';
6
7 // This file relies on the fact that the following declaration has been made
8 // in runtime.js:
9 // var $Array = global.Array;
10
11 // -------------------------------------------------------------------
12
13 macro TYPED_ARRAYS(FUNCTION)
14 // arrayIds below should be synchronized with Runtime_TypedArrayInitialize.
15 FUNCTION(1, Uint8Array, 1)
16 FUNCTION(2, Int8Array, 1)
17 FUNCTION(3, Uint16Array, 2)
18 FUNCTION(4, Int16Array, 2)
19 FUNCTION(5, Uint32Array, 4)
20 FUNCTION(6, Int32Array, 4)
21 FUNCTION(7, Float32Array, 4)
22 FUNCTION(8, Float64Array, 8)
23 FUNCTION(9, Uint8ClampedArray, 1)
24 endmacro
25
26
27 macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)
Dmitry Lomov (no reviews) 2014/10/14 16:10:25 Change macro name
aperez 2014/10/15 15:54:48 Acknowledged, changing to “TYPED_ARRAY_HARMONY_ADD
28
29 // ES6 draft 08-24-14, section 22.2.3.12
30 function NAMEForEach(f /* thisArg */) { // length == 1
31 if (!%IsTypedArray(this)) {
32 throw MakeTypeError('not_typed_array', []);
33 }
34 if (!IS_SPEC_FUNCTION(f)) {
35 throw MakeTypeError('called_non_callable', [ f ]);
36 }
37
38 var length = %_TypedArrayGetLength(this);
39 var receiver;
40
41 if (%_ArgumentsLength() > 1) {
42 receiver = %_Arguments(1);
43 }
44
45 var needs_wrapper = false;
46 if (IS_NULL_OR_UNDEFINED(receiver)) {
47 receiver = %GetDefaultReceiver(f) || receiver;
48 } else {
49 needs_wrapper = SHOULD_CREATE_WRAPPER(f, receiver);
Dmitry Lomov (no reviews) 2014/10/14 16:10:25 Add a test that exercises wrapper creation and non
aperez 2014/10/15 15:54:48 Acknowledged.
50 }
51
52 var stepping = DEBUG_IS_ACTIVE && %DebugCallbackSupportsStepping(f);
53 for (var i = 0; i < length; i++) {
54 var element = this[i];
55 // Prepare break slots for debugger step in.
56 if (stepping) %DebugPrepareStepInIfStepping(f);
57 var new_receiver = needs_wrapper ? ToObject(receiver) : receiver;
58 %_CallFunction(new_receiver, TO_OBJECT_INLINE(element), i, this, f);
59 }
60 }
61 endmacro
62
63 TYPED_ARRAYS(TYPED_ARRAY_CONSTRUCTOR)
64
65
66 function HarmonyTypedArrayExtendPrototypes() {
67 macro EXTEND_TYPED_ARRAY(ARRAY_ID, NAME, ELEMENT_SIZE)
68 %CheckIsBootstrapping();
69
70 // Set up non-enumerable functions on the prototype object.
71 InstallFunctions(global.NAME.prototype, DONT_ENUM, $Array(
72 "forEach", NAMEForEach
73 ));
74 endmacro
75
76 TYPED_ARRAYS(EXTEND_TYPED_ARRAY)
77 }
78
79 HarmonyTypedArrayExtendPrototypes();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698