Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 583703002: Annotate CaptureDumpPixels for MemorySanitizer. (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Annotate CaptureDumpPixels for MemorySanitizer. The snapshot pixels come from shared memory, which is initialized in the GPU process. MSan doesn't know what goes on in other processes, so we need to explicitly mark the pixels as initialized to silence MSan warnings. BUG=364724 TBR=piman@chromium.org NOTRY=true Committed: https://crrev.com/10538620e806691c97c63ba33d21900104b31eea Cr-Commit-Position: refs/heads/master@{#295490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/shell/renderer/webkit_test_runner.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 3 months ago (2014-09-18 17:46:21 UTC) #1
piman
lgtm
6 years, 3 months ago (2014-09-18 17:47:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583703002/1
6 years, 3 months ago (2014-09-18 17:48:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as e8647a26799f83d8a211a0b673c9885c8b5b3342
6 years, 3 months ago (2014-09-18 17:49:46 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:50:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10538620e806691c97c63ba33d21900104b31eea
Cr-Commit-Position: refs/heads/master@{#295490}

Powered by Google App Engine
This is Rietveld 408576698