[Android] Enable Partial O2 unconditionally on Release builds

[Android] Enable Partial O2 unconditionally on Release builds

Fastbuild does not imply "faster build". Setting it to 1 or 2
on Android implies no debug information is generated and
nothing more.

BUG=411909
Committed: https://crrev.com/45e80089827142cec7f37d71704f7d6d4d579689
Cr-Commit-Position: refs/heads/master@{#295475}

[Fabrice (no longer in Chrome), 2014-09-18 13:01:59]

fdegans@chromium.org changed reviewers:
+ pasko@chromium.org, sievers@chromium.org, skyostil@chromium.org,
thakis@chromium.org

[Fabrice (no longer in Chrome), 2014-09-18 13:01:59]

Adding the same reviewers as the previous CL, mostly FYI.
I'm hoping for the issue to be fixed on the bot configuration so we can revert
this after.

[Sami, 2014-09-18 13:59:42]

Wow, is there a bug for getting the bot config fixed?

Meanwhile, lgtm.

https://codereview.chromium.org/583593004/diff/20001/build/android/increase_s...
File build/android/increase_size_for_speed.gypi (right):

https://codereview.chromium.org/583593004/diff/20001/build/android/increase_s...
build/android/increase_size_for_speed.gypi:17: ['OS=="android" and (fastbuild==0
or component=="static_library")', {
Could you add a TODO here saying what this is for and that we should revert it.

[pasko, 2014-09-18 14:20:43]

+1 with what Sami requested

https://codereview.chromium.org/583593004/diff/20001/build/android/increase_s...
File build/android/increase_size_for_speed.gypi (right):

https://codereview.chromium.org/583593004/diff/20001/build/android/increase_s...
build/android/increase_size_for_speed.gypi:17: ['OS=="android" and (fastbuild==0
or component=="static_library")', {
On 2014/09/18 13:59:41, Sami wrote:
> Could you add a TODO here saying what this is for and that we should revert
it.

+1. Please make a bug, explain it here in a short sentence, and put a reference
to the bug here, put a TODO(fdegans) to remove the workaround.

[Fabrice (no longer in Chrome), 2014-09-18 14:24:44]

So, it turns out fastbuild is just poorly named.
Setting it to 1 or 2 implies no debug information is generated and nothing else.
I have removed the fastbuild test since it is not relevant here. We'll have the
relevant targets compiled with -O2, in component mode or not.

[Sami, 2014-09-18 14:45:01]

Ah, interesting. So no need to change the buildbot config then? lgtm if that's
the case.

[Fabrice (no longer in Chrome), 2014-09-18 14:46:05]

The CQ bit was checked by fdegans@chromium.org

[commit-bot: I haz the power, 2014-09-18 14:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583593004/40001

[Nico, 2014-09-18 15:21:21]

lgtm

[pasko, 2014-09-18 16:05:35]

lgtm++

[commit-bot: I haz the power, 2014-09-18 16:13:33]

Committed patchset #3 (id:40001) as 4f77fd408cc080416e6ad2f2c418ec1f9c08cf97

[commit-bot: I haz the power, 2014-09-18 16:14:07]

Patchset 3 (id:??) landed as
https://crrev.com/45e80089827142cec7f37d71704f7d6d4d579689
Cr-Commit-Position: refs/heads/master@{#295475}