Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 583593002: Changed 'copy link address' to 'copy email address' for mailto schemes (Closed)

Created:
6 years, 3 months ago by ankit
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer, Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changed 'copy link address' to 'copy email address' for mailto schemes When context menu is invoked for mailto schemes context menu should show 'copy email address' instead of 'copy link address'. BUG=415459 Committed: https://crrev.com/cac334a1c9fa759ba759610a4cfcd05adedce259 Cr-Commit-Position: refs/heads/master@{#295461}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/res/menu/chrome_context_menu.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ankit
@Bernhard, @Ted PTAL
6 years, 3 months ago (2014-09-18 10:21:13 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/583593002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java (right): https://codereview.chromium.org/583593002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java#newcode62 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:62: if (params.getLinkUrl().startsWith("mailto:")) { Use MailTo.isMailTo()? https://codereview.chromium.org/583593002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java#newcode138 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:138: } else ...
6 years, 3 months ago (2014-09-18 10:35:32 UTC) #3
ankit
@Bernhard PTAL new patch. https://codereview.chromium.org/583593002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java (right): https://codereview.chromium.org/583593002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java#newcode62 chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:62: if (params.getLinkUrl().startsWith("mailto:")) { On 2014/09/18 ...
6 years, 3 months ago (2014-09-18 10:45:20 UTC) #4
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-18 11:31:27 UTC) #5
ankit
On 2014/09/18 11:31:27, Bernhard Bauer wrote: > lgtm Thanks.
6 years, 3 months ago (2014-09-18 11:50:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583593002/20001
6 years, 3 months ago (2014-09-18 11:50:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b31889c7806bf1859f6f1ee0e03feb18f2a42a99
6 years, 3 months ago (2014-09-18 12:48:00 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 12:48:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cac334a1c9fa759ba759610a4cfcd05adedce259
Cr-Commit-Position: refs/heads/master@{#295461}

Powered by Google App Engine
This is Rietveld 408576698