Rename AppsClient -> AppWindowClient

extensions/browser/app_window/app_window_client.h

Index: extensions/browser/app_window/app_window_client.h
diff --git a/extensions/browser/app_window/apps_client.h b/extensions/browser/app_window/app_window_client.h
similarity index 82%
rename from extensions/browser/app_window/apps_client.h
rename to extensions/browser/app_window/app_window_client.h
index ee6459f1c16d4fc0daa33400fb489b8b3c35fe8e..7d69708e14c04f52d82141cbfb3c7ca655c52477 100644
--- a/extensions/browser/app_window/apps_client.h
+++ b/extensions/browser/app_window/app_window_client.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
-#define EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
+#ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_
+#define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_
 
 #include <vector>
 
@@ -22,11 +22,10 @@ class NativeAppWindow;
 
 // Sets up global state for the apps system. Should be Set() once in each
 // process. This should be implemented by the client of the apps system.
-// TODO(hashimoto): Move some functions to ExtensionsClient and rename this to
-// AppWindowClient.
-class AppsClient {
+// TODO(hashimoto): Move some functions to ExtensionsClient.

[oshima, 2014/09/18 21:39:32]

I'll leave this to hashimoto@ :)

[James Cook, 2014/09/18 22:29:12]

SGTM

GetLoadedBrowserContexts() should move to ExtensionsBrowserClient

IsCurrentChannelOlderThanDev() is not a good API function. I think we need
something that takes a channel string, like AllowFeatureFromChannel(const
std::string& feature_channel). This should live in ExtensionsClient.

hashimoto, do you have time to do this?  If you are busy, assign a bug to me and
I'll do it.

[hashimoto, 2014/09/19 02:44:37]

GetLoadedBrowserContexts() is used only by the following static methods of
AppWindowRegistry.
-AppWindowRegistry::GetAppWindowForNativeWindowAnyProfile
-AppWindowRegistry::IsAppWindowRegisteredInAnyProfile
-AppWindowRegistry::CloseAllAppWindows
Since all of them are used only by chrome, I began to think these static methods
should be split from AppWindowRegistry and put in somewhere (e.g.
src/apps/app_window_registry_util.{cc,h}) so that we can get rid of
GetLoadedBrowserContexts() from the client at all.
Do you think GetLoadedBrowserContexts() can be useful for binaries other than
chrome (e.g. app_shell and athena)?
Is it OK to mention the idea of "channels" in extensions code?
If it's OK, then maybe we should move
chrome/common/extensions/features/feature_channel.h to src/extensions?

[James Cook, 2014/09/19 03:26:06]

I don't think app_shell or athena will need GetLoadedBrowserContexts().  Moving
those static methods back into chrome sounds good.

Channels are complex. I filed a bug -- let's talk more there.
https://code.google.com/p/chromium/issues/detail?id=415861

+class AppWindowClient {
  public:
-  virtual ~AppsClient() {}
+  virtual ~AppWindowClient() {}
 
   // Get all loaded browser contexts.
   virtual std::vector<content::BrowserContext*> GetLoadedBrowserContexts() = 0;
@@ -54,12 +53,12 @@ class AppsClient {
   virtual bool IsCurrentChannelOlderThanDev() = 0;
 
   // Return the apps client.
-  static AppsClient* Get();
+  static AppWindowClient* Get();
 
   // Initialize the apps system with this apps client.
-  static void Set(AppsClient* client);
+  static void Set(AppWindowClient* client);
 };
 
 }  // namespace extensions
 
-#endif  // EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
+#endif  // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CLIENT_H_