Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 583583002: Tracing: fix missing comma between trace chunks written to file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index 73c4857ec74180ae0f00dbd0dd6b4f9a03c7563f..2362a1576377fec91a58f90a3beaf50315ef0cce 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -68,7 +68,9 @@ class FileTraceDataSink : public TracingController::TraceDataSink {
void AddTraceChunkOnFileThread(
const scoped_refptr<base::RefCountedString> chunk) {
- if (!OpenFileIfNeededOnFileThread())
+ if (file_ != NULL)
+ fputc(',', file_);
+ else if (!OpenFileIfNeededOnFileThread())
return;
ignore_result(fwrite(chunk->data().c_str(), strlen(chunk->data().c_str()),
1, file_));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698