Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 583573004: Fix broken home page overlay. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix broken home page overlay. BUG=415433 Committed: https://crrev.com/0db1f0168e66ae9cff63fdef2ad6e0a2ffeb1623 Cr-Commit-Position: refs/heads/master@{#295603}

Patch Set 1 #

Patch Set 2 : :| #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
D chrome/browser/resources/options/home_page_overlay.css View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 1 chunk +1 line, -5 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Evan Stade
posted screenshot on the bug https://codereview.chromium.org/583573004/diff/20001/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (left): https://codereview.chromium.org/583573004/diff/20001/chrome/browser/resources/options/options_page.css#oldcode349 chrome/browser/resources/options/options_page.css:349: html[dir=rtl].option-name { I assume ...
6 years, 3 months ago (2014-09-18 18:46:23 UTC) #2
Dan Beam
lgtm
6 years, 3 months ago (2014-09-18 20:35:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583573004/20001
6 years, 3 months ago (2014-09-18 20:36:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/15239)
6 years, 3 months ago (2014-09-18 21:40:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583573004/20001
6 years, 3 months ago (2014-09-18 22:24:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 50b1a02cc8b8c789deb14f05d7611633c19c774b
6 years, 3 months ago (2014-09-18 23:39:01 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:40:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0db1f0168e66ae9cff63fdef2ad6e0a2ffeb1623
Cr-Commit-Position: refs/heads/master@{#295603}

Powered by Google App Engine
This is Rietveld 408576698