Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 583573002: android_webview: Allow V8 to be built even when chromium is prebuilt. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: Allow V8 to be built even when chromium is prebuilt. When using a prebuilt libwebviewchromium, instead of skipping the entire directory just include the makefiles needed to build V8 for external/chromium-libpac to use. BUG= NOTRY=true Committed: https://crrev.com/cab385fa7a902ceafa27c303dafb25ef1780ff7b Cr-Commit-Position: refs/heads/master@{#295445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M Android.mk View 3 chunks +35 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
6 years, 3 months ago (2014-09-18 09:22:42 UTC) #2
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-18 09:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/583573002/1
6 years, 3 months ago (2014-09-18 10:12:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c25d60adaadd731e362adf65ab6e64847360930d
6 years, 3 months ago (2014-09-18 10:13:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 10:56:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab385fa7a902ceafa27c303dafb25ef1780ff7b
Cr-Commit-Position: refs/heads/master@{#295445}

Powered by Google App Engine
This is Rietveld 408576698