Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 58353002: chromium-status: make the limits field discoverable (Closed)

Created:
7 years, 1 month ago by vapier
Modified:
7 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-status: make the limits field discoverable People don't really know about the limit portion of the URL to load up more results. Add a link to the existing main line, and make sure the number reflects the reality of how many entries we are showing. It's a cheap way for users to notice things. BUG=chromium:314501 TEST=ran an appengine instance and checked the limit behavior/message TEST=`./tests/main_test.py` passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M status.py View 1 chunk +1 line, -0 lines 0 comments Download
M templates/main.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vapier
7 years, 1 month ago (2013-11-04 20:14:46 UTC) #1
cmp
lgtm
7 years, 1 month ago (2013-11-10 16:04:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/58353002/1
7 years, 1 month ago (2013-11-10 16:05:10 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 16:05:37 UTC) #4
Message was sent while issue was closed.
Change committed as 234177

Powered by Google App Engine
This is Rietveld 408576698