Issue 583503003: Simply remove dummy app icons from the home card.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 583503003: Simply remove dummy app icons from the home card. (Closed)

Created:
6 years, 3 months ago by Jun Mukai

Modified:
6 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Simply remove dummy app icons from the home card. BUG=415745 R=oshima@chromium.org TEST=manually Committed: https://crrev.com/f78b37a6991f70243eb029c295bb0cf5bf024e3d Cr-Commit-Position: refs/heads/master@{#295617}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -53 lines)			Patch
	M	athena/extensions/extension_app_model_builder.cc	View		2 chunks	+0 lines, -51 lines	0 comments	Download
	M	athena/home/athena_start_page_view.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583503003/1

6 years, 3 months ago (2014-09-18 22:44:41 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as ee67fd617ff805707f16c8323cda6a6c6ba112aa

6 years, 3 months ago (2014-09-19 00:11:06 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 00:12:01 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f78b37a6991f70243eb029c295bb0cf5bf024e3d
Cr-Commit-Position: refs/heads/master@{#295617}