Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: ipc/mojo/ipc_channel_mojo.cc

Issue 583473002: IPC: Get rid of FileDescriptor usage from FileDescriptorSet and Message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/mojo/ipc_channel_mojo.cc
diff --git a/ipc/mojo/ipc_channel_mojo.cc b/ipc/mojo/ipc_channel_mojo.cc
index 71c373e01cf07a63708871ae3077c121fc0f3e31..eb92d63f352dd094c55e76cd8eca8aaaccd06bc9 100644
--- a/ipc/mojo/ipc_channel_mojo.cc
+++ b/ipc/mojo/ipc_channel_mojo.cc
@@ -248,7 +248,8 @@ MojoResult ChannelMojo::WriteToFileDescriptorSet(
return unwrap_result;
}
- bool ok = message->file_descriptor_set()->Add(platform_handle.release().fd);
+ bool ok = message->file_descriptor_set()->AddToBorrow(
+ platform_handle.release().fd);
DCHECK(ok);
}
@@ -264,8 +265,10 @@ MojoResult ChannelMojo::ReadFromFileDescriptorSet(
// of FDs, so just to dup()-and-own them is the safest option.
if (message.HasFileDescriptors()) {
const FileDescriptorSet* fdset = message.file_descriptor_set();
- for (size_t i = 0; i < fdset->size(); ++i) {
- int fd_to_send = dup(fdset->GetDescriptorAt(i));
+ std::vector<base::PlatformFile> fds_to_send(fdset->size());
+ fdset->GetDescriptors(&fds_to_send[0]);
+ for (size_t i = 0; i < fds_to_send.size(); ++i) {
+ int fd_to_send = dup(fds_to_send[i]);
if (-1 == fd_to_send) {
DPLOG(WARNING) << "Failed to dup FD to transmit.";
return MOJO_RESULT_UNKNOWN;

Powered by Google App Engine
This is Rietveld 408576698