IPC: Get rid of FileDescriptor usage from FileDescriptorSet and Message

ipc/ipc_message.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message.h"
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
+#include "base/file_descriptor_posix.h"
 #include "ipc/file_descriptor_set_posix.h"
 #endif
 
 namespace {
 
 base::StaticAtomicSequenceNumber g_ref_num;
 
 // Create a reference number for identifying IPC messages in traces. The return
 // values has the reference number stored in the upper 24 bits, leaving the low
 // 8 bits set to 0 for use as flags.
@@ skipping 93 matching lines @@
   data -= sizeof(int64);
   return *(reinterpret_cast<const int64*>(data));
 }
 
 void Message::set_received_time(int64 time) const {
   received_time_ = time;
 }
 #endif
 
 #if defined(OS_POSIX)
-bool Message::WriteFileDescriptor(const base::FileDescriptor& descriptor) {
+bool Message::WriteFile(base::ScopedFD descriptor) {
   // We write the index of the descriptor so that we don't have to
   // keep the current descriptor as extra decoding state when deserialising.
   WriteInt(file_descriptor_set()->size());
-  if (descriptor.auto_close) {
-    return file_descriptor_set()->AddAndAutoClose(descriptor.fd);
-  } else {
-    return file_descriptor_set()->Add(descriptor.fd);
-  }
+  return file_descriptor_set()->AddToOwn(descriptor.Pass());
 }
 
-bool Message::ReadFileDescriptor(PickleIterator* iter,
-                                 base::FileDescriptor* descriptor) const {
+bool Message::WriteBorrowingFile(const base::PlatformFile& descriptor) {
+  // We write the index of the descriptor so that we don't have to
+  // keep the current descriptor as extra decoding state when deserialising.
+  WriteInt(file_descriptor_set()->size());
+  return file_descriptor_set()->AddToBorrow(descriptor);
+}
+
+bool Message::ReadFile(PickleIterator* iter, base::ScopedFD* descriptor) const {
   int descriptor_index;
   if (!ReadInt(iter, &descriptor_index))
     return false;
 
   FileDescriptorSet* file_descriptor_set = file_descriptor_set_.get();
   if (!file_descriptor_set)
     return false;
 
-  descriptor->fd = file_descriptor_set->GetDescriptorAt(descriptor_index);
-  descriptor->auto_close = true;
+  base::PlatformFile file =
+      file_descriptor_set->TakeDescriptorAt(descriptor_index);
+  if (file < 0)
+    return false;
 
-  return descriptor->fd >= 0;
+  descriptor->reset(file);
+  return true;
 }
 
 bool Message::HasFileDescriptors() const {
   return file_descriptor_set_.get() && !file_descriptor_set_->empty();
 }
 
 void Message::EnsureFileDescriptorSet() {
   if (file_descriptor_set_.get() == NULL)
     file_descriptor_set_ = new FileDescriptorSet;
 }
 
 #endif
 
 }  // namespace IPC