Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 583443005: Don't call ICoreWindow::Activate (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't call ICoreWindow::Activate Apparently (?) unnecessary, and it sometimes hangs in that call. This doesn't seem to help the 16s timeout (per tryjobs here), but doesn't seem to hurt either, and I can run on a local VM this way at least. BUG=411147 Committed: https://crrev.com/ab2f6b9ce3ba02a2bf397a1f3b875171cc9abdc4 Cr-Commit-Position: refs/heads/master@{#295594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M win8/metro_driver/chrome_app_view_ash.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
scottmg
6 years, 3 months ago (2014-09-18 00:39:55 UTC) #2
ananta
On 2014/09/18 00:39:55, scottmg wrote: LGTM % no sideeffects :). Is there any catch here?
6 years, 3 months ago (2014-09-18 00:52:47 UTC) #3
Shrikant Kelkar
On 2014/09/18 00:52:47, ananta wrote: > On 2014/09/18 00:39:55, scottmg wrote: > > LGTM % ...
6 years, 3 months ago (2014-09-18 01:12:13 UTC) #4
scottmg
On 2014/09/18 00:52:47, ananta wrote: > On 2014/09/18 00:39:55, scottmg wrote: > > LGTM % ...
6 years, 3 months ago (2014-09-18 04:54:50 UTC) #5
scottmg
On 2014/09/18 01:12:13, Shrikant Kelkar wrote: > On 2014/09/18 00:52:47, ananta wrote: > > On ...
6 years, 3 months ago (2014-09-18 17:13:08 UTC) #6
scottmg
On 2014/09/18 17:13:08, scottmg wrote: > On 2014/09/18 01:12:13, Shrikant Kelkar wrote: > > On ...
6 years, 3 months ago (2014-09-18 17:14:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583443005/1
6 years, 3 months ago (2014-09-18 21:54:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as d8be3e6d5db978afedeef9160e7927b33dbab88f
6 years, 3 months ago (2014-09-18 23:19:00 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:19:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab2f6b9ce3ba02a2bf397a1f3b875171cc9abdc4
Cr-Commit-Position: refs/heads/master@{#295594}

Powered by Google App Engine
This is Rietveld 408576698