Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/frame_host/navigation_entry_screenshot_manager.h

Issue 58343006: Rename WebContentsScreenshotManager to NavigationEntryScreenshotManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove TODO. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_screenshot_manager.h
diff --git a/content/browser/frame_host/web_contents_screenshot_manager.h b/content/browser/frame_host/navigation_entry_screenshot_manager.h
similarity index 77%
rename from content/browser/frame_host/web_contents_screenshot_manager.h
rename to content/browser/frame_host/navigation_entry_screenshot_manager.h
index 10339a2be9eea8d7bedd583ba6a5066edf042709..072d6fd4a7fe19a1111acdb6b2e5c6c470f92285 100644
--- a/content/browser/frame_host/web_contents_screenshot_manager.h
+++ b/content/browser/frame_host/navigation_entry_screenshot_manager.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_FRAME_HOST_WEB_CONTENTS_SCREENSHOT_MANAGER_H_
-#define CONTENT_BROWSER_FRAME_HOST_WEB_CONTENTS_SCREENSHOT_MANAGER_H_
+#ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_SCREENSHOT_MANAGER_H_
+#define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_SCREENSHOT_MANAGER_H_
#include "base/compiler_specific.h"
#include "base/memory/weak_ptr.h"
@@ -19,16 +19,15 @@ class NavigationEntryImpl;
class RenderViewHost;
class ScreenshotData;
-// WebContentsScreenshotManager takes care of taking image-captures for the
+// NavigationEntryScreenshotManager takes care of taking image-captures for the
// current navigation entry of a NavigationControllerImpl, and managing these
// captured images. These image-captures are used for history navigation using
// overscroll gestures.
-// TODO(nasko): Rename this to better reflect that it is used for
-// navigation entries and not WebContents.
-class CONTENT_EXPORT WebContentsScreenshotManager {
+class CONTENT_EXPORT NavigationEntryScreenshotManager {
public:
- explicit WebContentsScreenshotManager(NavigationControllerImpl* controller);
- virtual ~WebContentsScreenshotManager();
+ explicit NavigationEntryScreenshotManager(
+ NavigationControllerImpl* controller);
+ virtual ~NavigationEntryScreenshotManager();
// Takes a screenshot of the last-committed entry of the controller.
void TakeScreenshot();
@@ -77,15 +76,15 @@ class CONTENT_EXPORT WebContentsScreenshotManager {
// Taking a screenshot and encoding them can be async. So use a weakptr for
// the callback to make sure that the screenshot/encoding completion callback
- // does not trigger on a destroyed WebContentsScreenshotManager.
- base::WeakPtrFactory<WebContentsScreenshotManager> screenshot_factory_;
+ // does not trigger on a destroyed NavigationEntryScreenshotManager.
+ base::WeakPtrFactory<NavigationEntryScreenshotManager> screenshot_factory_;
base::Time last_screenshot_time_;
int min_screenshot_interval_ms_;
- DISALLOW_COPY_AND_ASSIGN(WebContentsScreenshotManager);
+ DISALLOW_COPY_AND_ASSIGN(NavigationEntryScreenshotManager);
};
} // namespace content
-#endif // CONTENT_BROWSER_FRAME_HOST_WEB_CONTENTS_SCREENSHOT_MANAGER_H_
+#endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_SCREENSHOT_MANAGER_H_

Powered by Google App Engine
This is Rietveld 408576698