Issue 58343006: Rename WebContentsScreenshotManager to NavigationEntryScreenshotManager.

Issue 58343006: Rename WebContentsScreenshotManager to NavigationEntryScreenshotManager. (Closed)

Created:
7 years, 1 month ago by nasko

Modified:
7 years, 1 month ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sadrul, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename WebContentsScreenshotManager to NavigationEntryScreenshotManager. BUG= R=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233049

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -412 lines)			Patch
M	content/browser/frame_host/navigation_controller_impl.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View		5 chunks	+6 lines, -6 lines	0 comments	Download
A +	content/browser/frame_host/navigation_entry_screenshot_manager.h	View	1	3 chunks	+11 lines, -12 lines	0 comments	Download
A +	content/browser/frame_host/navigation_entry_screenshot_manager.cc	View		8 chunks	+18 lines, -15 lines	0 comments	Download
D	content/browser/frame_host/web_contents_screenshot_manager.h	View		1 chunk	+0 lines, -91 lines	0 comments	Download
D	content/browser/frame_host/web_contents_screenshot_manager.cc	View		1 chunk	+0 lines, -273 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura_browsertest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nasko

Hey Charlie, This is a follow up from my moving of files to frame_host/. The ...

7 years, 1 month ago (2013-11-05 00:18:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/58343006/50001

7 years, 1 month ago (2013-11-05 14:34:26 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-05 14:53:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/58343006/50001

7 years, 1 month ago (2013-11-05 15:14:45 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185187

7 years, 1 month ago (2013-11-05 18:26:29 UTC) #6

nasko

7 years, 1 month ago (2013-11-05 19:11:34 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r233049 (presubmit successful).

Expand Messages | Collapse Messages