Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 58343005: Remove crtbeginS from the list of outputs from the PNaCl packager. (Closed)

Created:
7 years, 1 month ago by jvoung (off chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove crtbeginS from the list of outputs from the PNaCl packager. crtbeginS was removed from PNaCl as part of PNaCl+glibc cleanup. If we continue listing crtbeginS as part of the gyp outputs list, ninja will think we need to rebuild. BUG=313636 TEST=ninja nop build && browser_tests --gtest_filter=*Pnacl* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jvoung (off chromium)
7 years, 1 month ago (2013-11-04 23:43:07 UTC) #1
Mark Seaborn
LGTM
7 years, 1 month ago (2013-11-04 23:44:31 UTC) #2
Derek Schuff
lgtm
7 years, 1 month ago (2013-11-05 00:20:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/58343005/1
7 years, 1 month ago (2013-11-05 00:29:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/58343005/1
7 years, 1 month ago (2013-11-05 03:28:58 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 06:20:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/58343005/1
7 years, 1 month ago (2013-11-05 06:50:09 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 16:11:46 UTC) #8
Message was sent while issue was closed.
Change committed as 232997

Powered by Google App Engine
This is Rietveld 408576698