Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 58343004: Allow stacking below windows with layers with NULL delegates. (Closed)

Created:
7 years, 1 month ago by flackr
Modified:
7 years, 1 month ago
Reviewers:
pkotwicz, sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Allow stacking below windows with layers with NULL delegates. BUG=313301 TEST=WindowTest.StackWindowAtBottomBelowWindowWhoseLayerHasNoDelegate Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232946

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M ui/aura/window.cc View 1 chunk +4 lines, -6 lines 1 comment Download
M ui/aura/window_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
flackr
PTAL, thanks. https://codereview.chromium.org/58343004/diff/1/ui/aura/window.cc File ui/aura/window.cc (right): https://codereview.chromium.org/58343004/diff/1/ui/aura/window.cc#newcode897 ui/aura/window.cc:897: final_target_i - 1]->layer() This change should make ...
7 years, 1 month ago (2013-11-04 22:04:12 UTC) #1
pkotwicz
LGTM
7 years, 1 month ago (2013-11-04 22:13:05 UTC) #2
flackr
Thanks! +sky, PTAL.
7 years, 1 month ago (2013-11-04 22:16:07 UTC) #3
sky
LGTM
7 years, 1 month ago (2013-11-04 22:24:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/58343004/1
7 years, 1 month ago (2013-11-04 22:50:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218995
7 years, 1 month ago (2013-11-05 01:48:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/58343004/1
7 years, 1 month ago (2013-11-05 02:40:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/58343004/1
7 years, 1 month ago (2013-11-05 03:28:39 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:26:02 UTC) #9
Message was sent while issue was closed.
Change committed as 232946

Powered by Google App Engine
This is Rietveld 408576698