Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 583423002: Revert of Make mojo/services pass in "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ui
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/bindings/gl/BUILD.gn ('k') | mojo/services/clipboard/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index 74e6153a9c093d9dfeb4b32d402afff755364850..d1637395e5b193f3ec6d6498a29067d39f49e5d3 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -12,8 +12,10 @@
# List of source .mojom files to compile.
#
# deps (optional)
-# public_deps (optional)
+#
# visibility (optional)
+# Normal meaning. However, this must be a list (normal visibility
+# allows a single string).
template("mojom") {
assert(defined(invoker.sources),
"\"sources\" must be defined for the $target_name template.")
@@ -83,7 +85,7 @@
target_visibility = [ ":$target_name" ]
}
- generator_target_name = target_name + "__generator"
+ generator_target_name = target_name + "_generator"
action_foreach(generator_target_name) {
if (defined(invoker.visibility)) {
visibility = target_visibility + invoker.visibility
@@ -116,8 +118,5 @@
if (defined(invoker.deps)) {
deps += invoker.deps
}
- if (defined(invoker.public_deps)) {
- public_deps = invoker.public_deps
- }
}
}
« no previous file with comments | « mojo/apps/js/bindings/gl/BUILD.gn ('k') | mojo/services/clipboard/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698