Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 583403002: [Easy signin] Update the logic for getting user device list from cryptohome (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy signin] Update the logic for getting user device list from cryptohome * Add retry logic if initial loads fail (to handle the case cryptohome service has not yet started) * Cache the loaded results. BUG=401634 Committed: https://crrev.com/5f2d92c54f1e5e3164922d9b6ab330fd59a271b8 Cr-Commit-Position: refs/heads/master@{#296056}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -56 lines) Patch
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 2 chunks +51 lines, -16 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 2 3 4 4 chunks +133 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tbarzic
split off from https://codereview.chromium.org/576343002/
6 years, 3 months ago (2014-09-19 23:29:49 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/583403002/diff/60001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right): https://codereview.chromium.org/583403002/diff/60001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc#newcode22 chrome/browser/signin/easy_unlock_service_signin_chromeos.cc:22: size_t kMaxCryptohomeBackoffIntervalMs = 10000u; nit: size_t -> uint32
6 years, 3 months ago (2014-09-22 20:12:44 UTC) #3
tbarzic
https://codereview.chromium.org/583403002/diff/60001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right): https://codereview.chromium.org/583403002/diff/60001/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc#newcode22 chrome/browser/signin/easy_unlock_service_signin_chromeos.cc:22: size_t kMaxCryptohomeBackoffIntervalMs = 10000u; On 2014/09/22 20:12:43, xiyuan wrote: ...
6 years, 3 months ago (2014-09-22 20:22:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583403002/80001
6 years, 3 months ago (2014-09-22 20:23:46 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as d110be33ada76a3388d309a8a31000241f18b492
6 years, 3 months ago (2014-09-22 21:34:42 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 21:35:22 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5f2d92c54f1e5e3164922d9b6ab330fd59a271b8
Cr-Commit-Position: refs/heads/master@{#296056}

Powered by Google App Engine
This is Rietveld 408576698