build/common.gypi - Issue 583363004: Linux: Turn --icf=safe back on for the gold linker. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 583363004: Linux: Turn --icf=safe back on for the gold linker. (try 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 6ce27f6aaec89cd6a4bf13246c3d026a85b8e478..e10497d34f02c6a6a6b3a14bdedaafb5d87ce4b8 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4314,12 +4314,7 @@

'target_conditions': [

['_toolset=="target"', {

'ldflags': [

- # There seems to be a conflict of --icf and -pie

- # in gold which can generate crashy binaries. As

- # a security measure, -pie takes precedence for

- # now.

- #'-Wl,--icf=safe',

- '-Wl,--icf=none',

+ '-Wl,--icf=safe',

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »