Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 583363003: GN: Fix dependency output file handling. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Fix dependency output file handling. A copy and paste error meant it used the link output file for dependency tracking. This is valid but inefficient, which was why it wasn't caught. Added a new test for this case R=scottmg@chromium.org Committed: https://crrev.com/4fab8a0b3d7e2ae3db541795783b41911ad8c711 Cr-Commit-Position: refs/heads/master@{#295985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M tools/gn/substitution_pattern.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/substitution_pattern.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/target_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-19 22:54:49 UTC) #2
scottmg
LGTM
6 years, 3 months ago (2014-09-19 23:02:39 UTC) #3
brettw
Committed patchset #1 (id:1) to pending queue manually as 96be36d (presubmit successful).
6 years, 3 months ago (2014-09-22 16:31:39 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:32:35 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fab8a0b3d7e2ae3db541795783b41911ad8c711
Cr-Commit-Position: refs/heads/master@{#295985}

Powered by Google App Engine
This is Rietveld 408576698