Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5366)

Unified Diff: chrome/common/extensions/api/cast_streaming_udp_transport.idl

Issue 583353003: Cast: missing transport ID in setOptions API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/cast_streaming_udp_transport.idl
diff --git a/chrome/common/extensions/api/cast_streaming_udp_transport.idl b/chrome/common/extensions/api/cast_streaming_udp_transport.idl
index 7532c6517fb6f055d5d965296acc28cbc9aa1e6e..36193270e43d8a4cb1b3488cce0d31dc182d3ee7 100644
--- a/chrome/common/extensions/api/cast_streaming_udp_transport.idl
+++ b/chrome/common/extensions/api/cast_streaming_udp_transport.idl
@@ -31,6 +31,11 @@ namespace cast.streaming.udpTransport {
// Attributes of this object will be used to activate optional
// behaviours in the transport. Normally this is only used for
// experimentation. Must be called before setDestination.
- [nocompile] static void setOptions(object options);
+ // |transportId| : The transport ID.
scheib 2014/09/23 15:26:28 Please comment where transportId comes from (espec
+ // |options| : A dictionary of key-value pairs of options.
+ // See media/cast/net/cast_transport_sender_impl.h for supported
+ // options.
+ [nocompile] static void setOptions(long transportId,
+ object options);
};
};
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698