Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 583353003: Cast: missing transport ID in setOptions API (Closed)

Created:
6 years, 3 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
Reviewers:
scheib, hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: missing transport ID in setOptions API Adding missing field of transportId to cast.streaming.udpTransport.setOptions() API. The API is now working. Committed: https://crrev.com/a88205dd956cbcbabf9605d2607dd99d2ed07646 Cr-Commit-Position: refs/heads/master@{#296274}

Patch Set 1 #

Patch Set 2 : running #

Total comments: 2

Patch Set 3 : comments #

Total comments: 1

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/common/extensions/api/cast_streaming_udp_transport.idl View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/cast_streaming_udp_transport_custom_bindings.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/basics.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Alpha Left Google
+scheib for idl changes.
6 years, 3 months ago (2014-09-22 18:42:25 UTC) #3
scheib
https://codereview.chromium.org/583353003/diff/20001/chrome/common/extensions/api/cast_streaming_udp_transport.idl File chrome/common/extensions/api/cast_streaming_udp_transport.idl (right): https://codereview.chromium.org/583353003/diff/20001/chrome/common/extensions/api/cast_streaming_udp_transport.idl#newcode35 chrome/common/extensions/api/cast_streaming_udp_transport.idl:35: // |options| : A dictionary of key-value pairs of ...
6 years, 3 months ago (2014-09-22 22:49:46 UTC) #4
Alpha Left Google
https://codereview.chromium.org/583353003/diff/20001/chrome/common/extensions/api/cast_streaming_udp_transport.idl File chrome/common/extensions/api/cast_streaming_udp_transport.idl (right): https://codereview.chromium.org/583353003/diff/20001/chrome/common/extensions/api/cast_streaming_udp_transport.idl#newcode35 chrome/common/extensions/api/cast_streaming_udp_transport.idl:35: // |options| : A dictionary of key-value pairs of ...
6 years, 3 months ago (2014-09-22 23:06:32 UTC) #5
scheib
lgtm with transportId commented. https://codereview.chromium.org/583353003/diff/40001/chrome/common/extensions/api/cast_streaming_udp_transport.idl File chrome/common/extensions/api/cast_streaming_udp_transport.idl (right): https://codereview.chromium.org/583353003/diff/40001/chrome/common/extensions/api/cast_streaming_udp_transport.idl#newcode34 chrome/common/extensions/api/cast_streaming_udp_transport.idl:34: // |transportId| : The transport ...
6 years, 3 months ago (2014-09-23 15:26:29 UTC) #6
Alpha Left Google
On 2014/09/23 15:26:29, scheib wrote: > lgtm with transportId commented. > > https://codereview.chromium.org/583353003/diff/40001/chrome/common/extensions/api/cast_streaming_udp_transport.idl > File ...
6 years, 3 months ago (2014-09-23 18:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583353003/60001
6 years, 3 months ago (2014-09-23 20:31:24 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 913644f15fb631d5f375d55f994402f6dc0b31e0
6 years, 3 months ago (2014-09-23 22:01:11 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:01:46 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a88205dd956cbcbabf9605d2607dd99d2ed07646
Cr-Commit-Position: refs/heads/master@{#296274}

Powered by Google App Engine
This is Rietveld 408576698