Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 583353002: Work toward enabling WebRTC in the GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Work toward enabling WebRTC in the GN build. With some changes in libvpx and webrtc, plus this change, we should be able to enable webrtc in the GN build. R=hclam@chromium.org Committed: https://crrev.com/1b23fbf36010d43c26541452335f746eeab18bfd Cr-Commit-Position: refs/heads/master@{#295784}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M content/browser/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 7 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
6 years, 3 months ago (2014-09-19 20:39:39 UTC) #2
Alpha Left Google
lgtm
6 years, 3 months ago (2014-09-19 20:40:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583353002/20001
6 years, 3 months ago (2014-09-19 20:53:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12257)
6 years, 3 months ago (2014-09-19 21:10:50 UTC) #7
brettw
Committed patchset #2 (id:20001) manually as 1b23fbf.
6 years, 3 months ago (2014-09-19 21:30:28 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 21:30:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b23fbf36010d43c26541452335f746eeab18bfd
Cr-Commit-Position: refs/heads/master@{#295784}

Powered by Google App Engine
This is Rietveld 408576698