Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 583333002: Typedefs don't support generic arguments yet. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
index 7fb8b3efd6e8561e40abe77291d6abbb60fc29f5..af3226e9391822a9d3eb0892585874171ebcd583 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
@@ -591,8 +591,13 @@ TypeMirror reflectClassByName(Symbol symbol, String mangledName) {
disableTreeShaking();
int typeArgIndex = mangledName.indexOf("<");
if (typeArgIndex != -1) {
- mirror = new JsTypeBoundClassMirror(reflectClassByMangledName(
- mangledName.substring(0, typeArgIndex)).originalDeclaration,
+ TypeMirror originalDeclaration =
+ reflectClassByMangledName(mangledName.substring(0, typeArgIndex))
+ .originalDeclaration;
+ if (originalDeclaration is JsTypedefMirror) {
+ throw new UnimplementedError();
+ }
+ mirror = new JsTypeBoundClassMirror(originalDeclaration,
// Remove the angle brackets enclosing the type arguments.
mangledName.substring(typeArgIndex + 1, mangledName.length - 1));
JsCache.update(classMirrors, mangledName, mirror);
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698