Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 583283003: Add uint128_struct and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add uint128_struct and its test. This will be used in the upcoming Minidump context structures. This also updates mini_chromium to ba9b15f1b6a7 to pick up: ba9b15f1b6a7 Make bit_cast available in C++11 mode. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fee5d8aea971a1c8e5415afd5510f966ed0404d6

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A util/numeric/int128.h View 1 chunk +50 lines, -0 lines 0 comments Download
A util/numeric/int128_test.cc View 1 chunk +42 lines, -0 lines 3 comments Download
M util/util.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-22 18:51:55 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc File util/numeric/int128_test.cc (right): https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc#newcode34 util/numeric/int128_test.cc:34: COMPILE_ASSERT(sizeof(uint128) == sizeof(kBytes), sizes_must_be_equal); Maybe also something simpler: ...
6 years, 3 months ago (2014-09-22 19:02:14 UTC) #3
Mark Mentovai
https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc File util/numeric/int128_test.cc (right): https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc#newcode34 util/numeric/int128_test.cc:34: COMPILE_ASSERT(sizeof(uint128) == sizeof(kBytes), sizes_must_be_equal); rsesek wrote: > Maybe also ...
6 years, 3 months ago (2014-09-22 19:41:20 UTC) #4
Mark Mentovai
Committed patchset #1 (id:1) manually as fee5d8a (presubmit successful).
6 years, 3 months ago (2014-09-22 19:46:05 UTC) #5
Robert Sesek
6 years, 3 months ago (2014-09-22 19:46:12 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc
File util/numeric/int128_test.cc (right):

https://codereview.chromium.org/583283003/diff/1/util/numeric/int128_test.cc#...
util/numeric/int128_test.cc:34: COMPILE_ASSERT(sizeof(uint128) ==
sizeof(kBytes), sizes_must_be_equal);
On 2014/09/22 19:41:20, Mark Mentovai wrote:
> rsesek wrote:
> > Maybe also something simpler: COMPILE_ASSERT(8 * sizeof(uint128) == 128).
> 
> Well, I’m testing that it’s safe to bit_cast between the two, so I wanted to
> have both variables in the expression.

I meant "in addition to".

Powered by Google App Engine
This is Rietveld 408576698