Fix app list duplication on drag.

Fix app list duplication on drag.

This CL fixes a bug where drop targets were not being calculated correctly
which led to duplication on reparents.

BUG=415530
TEST=Drag an app from inside a folder onto the page switcher. The app
should disappear from the folder and appear in the root grid.

Committed: https://crrev.com/eaae121b61b3b89786061383919122e669bf4deb
Cr-Commit-Position: refs/heads/master@{#296125}

[calamity, 2014-09-22 06:22:14]

calamity@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2014-09-22 06:47:03]

lgtm with the test neatened up a bit

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
File ui/app_list/views/app_list_main_view_unittest.cc (right):

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:295: const int kInitialApps =
20;
nit: I'd just drop this var and put 20 on the next line (also, sky taught me
recently that function-local consts don't get special treatment :), so if you
want to keep it, kInitialApps -> initial_apps)

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:308:
SimulateUpdateDrag(FolderGridView(), AppsGridView::MOUSE, dragged, point);
Why two? (comment?). But I'm pretty sure you can drop one, since the drag is
already ongoing at this point (only StartDragForReparent needs two)

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:310:
base::RunLoop().RunUntilIdle();
yeah - as discussed - probably don't need these.

[calamity, 2014-09-23 01:06:23]

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
File ui/app_list/views/app_list_main_view_unittest.cc (right):

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:295: const int kInitialApps =
20;
On 2014/09/22 06:47:02, tapted wrote:
> nit: I'd just drop this var and put 20 on the next line (also, sky taught me
> recently that function-local consts don't get special treatment :), so if you
> want to keep it, kInitialApps -> initial_apps)

Done.

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:308:
SimulateUpdateDrag(FolderGridView(), AppsGridView::MOUSE, dragged, point);
On 2014/09/22 06:47:02, tapted wrote:
> Why two? (comment?). But I'm pretty sure you can drop one, since the drag is
> already ongoing at this point (only StartDragForReparent needs two)

Indeed.

https://codereview.chromium.org/583263004/diff/1/ui/app_list/views/app_list_m...
ui/app_list/views/app_list_main_view_unittest.cc:310:
base::RunLoop().RunUntilIdle();
On 2014/09/22 06:47:02, tapted wrote:
> yeah - as discussed - probably don't need these.

Done.

[calamity, 2014-09-23 01:06:28]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-23 01:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583263004/20001

[commit-bot: I haz the power, 2014-09-23 01:49:26]

Committed patchset #2 (id:20001) as 0bfc75f1cfa03f65572a8bf210a5c3fcf41d2c51

[commit-bot: I haz the power, 2014-09-23 01:50:10]

Patchset 2 (id:??) landed as
https://crrev.com/eaae121b61b3b89786061383919122e669bf4deb
Cr-Commit-Position: refs/heads/master@{#296125}