Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 583263003: GN: Build //base with USE_SYMBOLIZE on Linux (Closed)

Created:
6 years, 3 months ago by Chris Masone
Modified:
6 years, 3 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Build //base with USE_SYMBOLIZE on Linux In base.gyp, USE_SYMBOLIZE is added for Desktop Linux and Chrome OS builds for both base and base_unittests. In the GN build, it's added for 'is_linux' builds (which does not include Android), but only for base_unittests. This adds the define for //base as well. BUG=335824 TEST=build base and base_unittests, make a debug build and force a DCHECK() -- you should get a useful stack trace R=scottmg@chromium.org Committed: https://crrev.com/f324157fb51248250b91a87cd3d30a8928b79077 Cr-Commit-Position: refs/heads/master@{#295885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Chris Masone
PTAL
6 years, 3 months ago (2014-09-20 00:50:43 UTC) #1
scottmg
lgtm
6 years, 3 months ago (2014-09-20 02:11:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583263003/1
6 years, 3 months ago (2014-09-20 02:14:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12388)
6 years, 3 months ago (2014-09-20 02:31:08 UTC) #6
scottmg
+brettw owners
6 years, 3 months ago (2014-09-20 06:01:27 UTC) #8
brettw
lgtm
6 years, 3 months ago (2014-09-20 06:02:32 UTC) #9
Chris Masone
On 2014/09/20 06:02:32, brettw wrote: > lgtm Ah, thanks!
6 years, 3 months ago (2014-09-20 19:09:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583263003/1
6 years, 3 months ago (2014-09-20 19:10:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as f1a3d5ce93c49c7ff9f5eb76f54da34b232ddaaf
6 years, 3 months ago (2014-09-20 19:14:40 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 19:15:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f324157fb51248250b91a87cd3d30a8928b79077
Cr-Commit-Position: refs/heads/master@{#295885}

Powered by Google App Engine
This is Rietveld 408576698